chore(decide): More meaningful profiling #17729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
approved these changes
Oct 3, 2023
| return event if random() < 0.5 else None | ||
|
|
||
| except Exception: | ||
| return event if should_sample else None |
There was a problem hiding this comment.
nit picking that this could be a pass or a log and line 43 would still take effect...
There was a problem hiding this comment.
makes sense! but out of laziness / not wanting to wait for tests to pass again, I''l go ahead and merge, will fix this if this PR doesn't work 馃槀 馃檲
xvello
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The previous PR was a fail: #17712 - since there's only a fraction of requests that fall into the spiking category, and we were blowing through our budget with a higher sampling rate. (thanks for flagging @fuziontech !)
So, I spent some time going through the weeds of sentry source code (ugh the docs are terrible for this - ChatGPT hints were surprisingly useful!) - to find a way to sample based on request duration. Now, based on how long the request took, we can have varying sampling rates.
Also adds a few more spans to decide for better observability.
For best reviewing experience, hide whitespace changes in the diff.
Changes
馃憠 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Run locally, setup a sentry DSN, find events come in appropriately for decide, and confirm other endpoints are not affected