Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retention date filtering #1788

Merged
merged 27 commits into from
Oct 14, 2020
Merged

Retention date filtering #1788

merged 27 commits into from
Oct 14, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Oct 1, 2020

Changes

Please describe.
If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-retention-date--fnknnf October 1, 2020 11:49 Inactive
@mariusandra
Copy link
Collaborator

This test might be automatically fixed with these changes:

# TODO: remove this check

@timgl timgl temporarily deployed to posthog-retention-date--q0sm6v October 1, 2020 12:51 Inactive
@timgl timgl temporarily deployed to posthog-retention-date--kv4nwq October 1, 2020 13:32 Inactive
@timgl timgl temporarily deployed to posthog-retention-date--msz6ak October 1, 2020 16:57 Inactive
@timgl timgl temporarily deployed to posthog-retention-date--vfkcjy October 1, 2020 17:06 Inactive
@timgl timgl temporarily deployed to posthog-retention-date--zsmwhh October 1, 2020 17:20 Inactive
@EDsCODE EDsCODE marked this pull request as ready for review October 2, 2020 08:35
@timgl timgl temporarily deployed to posthog-retention-date--74vk93 October 2, 2020 08:35 Inactive
@timgl timgl temporarily deployed to posthog-retention-date--1jj4pm October 2, 2020 09:31 Inactive
@timgl timgl temporarily deployed to posthog-retention-date--luppfg October 2, 2020 10:07 Inactive
@EDsCODE EDsCODE requested a review from timgl October 2, 2020 10:11
@@ -52,6 +54,35 @@ export function RetentionTab(): JSX.Element {
<hr />
<h4 className="secondary">Filters</h4>
<PropertyFilters pageKey="insight-retention" />
{posthog.isFeatureEnabled('ch-retention-endpoint') && (
Copy link
Member Author

@EDsCODE EDsCODE Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timgl Do I need to init posthog somewhere again? It seems we do

@timgl timgl temporarily deployed to posthog-retention-date--vb6nru October 2, 2020 10:17 Inactive
@timgl timgl temporarily deployed to posthog-retention-date--hv8nnz October 2, 2020 10:36 Inactive
@EDsCODE EDsCODE merged commit 2d60a5b into master Oct 14, 2020
@EDsCODE EDsCODE deleted the retention-date-filtering branch October 14, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants