Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change session query to not collect events #1802

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Oct 2, 2020

Changes

Please describe.
If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-ch-sessions-new-hodufa October 2, 2020 13:25 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-ch-sessions-new-hodufa October 2, 2020 15:23 Inactive
Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send it

@EDsCODE EDsCODE merged commit 3a89825 into master Oct 2, 2020
@EDsCODE EDsCODE deleted the ch-sessions-new-query branch October 2, 2020 18:05
@mariusandra
Copy link
Collaborator

Hmm. What about the frontend?

@EDsCODE
Copy link
Member Author

EDsCODE commented Oct 2, 2020

This is only for the insight session metric that just aggregates

We left the oher query in too so list work (but that’s going to need optimizing because when we grouparray on events it blows up clickhouse memory and query fails)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants