Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar Shadow Root Support #1805

Merged
merged 11 commits into from
Oct 7, 2020
Merged

Toolbar Shadow Root Support #1805

merged 11 commits into from
Oct 7, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

  • Start using query-selector-shadow-dom to query elements inside shadow roots. Using a custom version until a PR is merged upstream that fixes the selector syntax used by simmer... and adds a performance optimisation. This library lets us write selectors that span shadow root boundaries.
  • Upgrade to a new version of simmer, which supports shadow roots and custom elements plus fixes some bugs. (Changes)
  • Add shadow root support to toolbar "inspect element" and "heatmap" features
  • Fix a few small UX issues (shouldn't autoselect "selector" if simmer returns nothing, clarify that "URL" means the "URL of the current page", not the URL of the link)

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@mariusandra mariusandra requested a review from timgl October 3, 2020 07:47
@timgl timgl temporarily deployed to posthog-toolbar-shadow--sr2wlo October 3, 2020 07:48 Inactive
@timgl timgl temporarily deployed to posthog-toolbar-shadow--jyo5an October 3, 2020 07:57 Inactive
@timgl timgl temporarily deployed to posthog-toolbar-shadow--y68jy7 October 3, 2020 08:17 Inactive
Twixes
Twixes approved these changes Oct 7, 2020
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though difficult to test this.

@mariusandra mariusandra merged commit 5729fb5 into master Oct 7, 2020
@mariusandra mariusandra deleted the toolbar-shadow-root branch October 7, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mariusandra @Twixes @timgl