Fix small util bugs #1871
Merged
Fix small util bugs #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusandra
approved these changes
Oct 14, 2020
macobo
reviewed
Oct 14, 2020
| const regex = new RegExp(expression) | ||
| return !!string.match(regex) | ||
| const regexp = /^\s*https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&//=]*)/gi | ||
| return !!string.match?.(regexp) |
There was a problem hiding this comment.
Q: Why do we need the ?? In this context string is not null right?
There was a problem hiding this comment.
Ideally this would always be a string, but I made a small mistake in this func when moving the file from JS to TS, by removing this check that some JS, non-type respecting parts of the codebase relied on.
There was a problem hiding this comment.
If the signature is lying (this is called with null/undefined) I'd say it's also worth updating the method signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Small but impactful bugs caused by migration to TS.