Use posthog.js correctly in userLogic #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
reviewed
Oct 22, 2020
macobo
force-pushed
the
fix-1955-confusion
branch
from
b057b7e
to
1c17a3b
Compare
This caused some confusion (issue #1955) - we should be using our own tools correctly. 馃槄
macobo
force-pushed
the
fix-1955-confusion
branch
from
1c17a3b
to
872fc8f
Compare
|
@timgl Updated this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused some confusion (issue #1955) - we should be using our own tools correctly. 馃槄
Types could have avoided this, but adding PH typing here is surprisingly hard - doing follow-up PRs.