Make PostHog compatibile with Python 3.9 #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
timgl
reviewed
Oct 22, 2020
| @@ -318,7 +318,7 @@ def test_breakdown_filtering(self): | |||
|
|
|||
| self.assertEqual(sum(response[0]["data"]), 2) | |||
| self.assertEqual(response[0]["data"][4 + 7], 2) | |||
| self.assertEqual(response[0]["breakdown_value"], "None") | |||
There was a problem hiding this comment.
This will possibly mess stuff up in the frontend?
There was a problem hiding this comment.
I haven't found any comparison to 'None' in the frontend code base, so think this shouldn't affect it (unless I'm missing some value handling somewhere).
There was a problem hiding this comment.
appUrlsLogic.js:45 relies on it being true/false (rather than 'nan'), same for trendsLogic.js:100.
There was a problem hiding this comment.
This looks like it was a truthy string anyway though, as in "None", not None.
|
@timgl If we want to test multiple Python versions, could you un-require "Django tests" (without " – Py ...") so that this is mergeable? Unless we don't want that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Python 3.9.0 has been released and all of PostHog seems to be compatible with it – except for Pandas 1.0.3, which had installation issues on the updated CPython. This fixes that by updating Pandas to 1.1.3.