Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break down feature_flag_response and add to propertykeyinfo #1991

Merged
merged 1 commit into from Oct 23, 2020
Merged

Break down feature_flag_response and add to propertykeyinfo #1991

merged 1 commit into from Oct 23, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Oct 22, 2020 •
edited

Changes

We weren't breaking down by the response, so you couldn't actually tell what gate the feature flag went through. Now we automatically show that breakdown: (this is clickhouse sessions)

image

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-improve-feature-kvmtiw October 22, 2020 16:06 Inactive
@macobo macobo merged commit 583d796 into master Oct 23, 2020
@macobo macobo deleted the improve-feature-flags branch October 23, 2020 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @macobo