Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohorts Test #2003

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Cohorts Test #2003

merged 2 commits into from
Oct 23, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

  • Adds test to create new cohorts and then open the cohort

  • Will avoid the cohorts table links breaking like just happened

  • Also added: fix the flaky tests by sending { force: true } to clicks to property list dropdowns. This will make the code click the dropdown item, even if it's hidden from CSS due to timing issues if clicking the original dropdown field to open it... and then it closes because an autofocus already opened it.

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-cohorts-test-zabdi5xyl October 23, 2020 10:06 Inactive
@Twixes Twixes merged commit e4895ba into master Oct 23, 2020
@Twixes Twixes deleted the cohorts-test branch October 23, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants