Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix click outside spam & public paths #2022

Merged
merged 3 commits into from Oct 26, 2020
Merged

Fix click outside spam & public paths #2022

merged 3 commits into from Oct 26, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

Fixes two things:

  • The "../../../../../../../../../../public/something.jpg" urls are now "public/something.jpg".
  • I got tired of having redux spam with the click outside hook, so I added an if statement there:

image

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-fix-click-outsi-kf51cu October 26, 2020 10:24 Inactive
Twixes
Twixes approved these changes Oct 26, 2020
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Twixes Twixes temporarily deployed to posthog-fix-click-outsi-kf51cu October 26, 2020 11:24 Inactive
@mariusandra mariusandra merged commit 034ba7e into master Oct 26, 2020
@mariusandra mariusandra deleted the fix-click-outside branch October 26, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mariusandra @macobo @Twixes @timgl