Use uuids in funnels for consistency #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDsCODE
reviewed
Oct 26, 2020
| @@ -102,7 +102,7 @@ def run(self, *args, **kwargs) -> List[Dict[str, Any]]: | |||
| res = [] | |||
| for result_tuple in results: | |||
| result = list(result_tuple) | |||
| person = Person(pk=result[0]) | |||
| person = Person(pk=result[0], uuid=result[0]) | |||
There was a problem hiding this comment.
how is this used later? this seems to be begging for type incompatibility
There was a problem hiding this comment.
Hm not sure I understand the question. It's used in queries/funnel.py in data_to_return. We only use the uuid now. How do you think we could improve this?
EDsCODE
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes funnels not loading in clickhouse and also this sentry error: https://sentry.io/organizations/posthog/issues/1926590421/?project=1899813&query=is%3Aunresolved
Checklist