feat(hogql): implement include_recordings for funnel actors #20503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2024
thmsobrmlr
force-pushed
the
funnel-actors-recordings
branch
from
dbe5e03
to
65ec5f6
Compare
|
Size Change: -234 B (0%) Total Size: 815 kB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
mariusandra
approved these changes
Feb 28, 2024
pauldambra
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Funnels need to be converted to HogQL (see the funnels section in PostHog/meta#130).
Changes
This PR adds an option to include recordings for funnel actors and uses this option frontend-side.
Unfortunately the recordings are not clickable on the frontend yet, since they are not serialized to actual recordings. This issue exists with other HogQL insights as well, if I understand correctly, and is not related specifically to funnels.
How did you test this code?
Converted existing funnel tests and played around locally