Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clickhouse never calculate action #2059

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Clickhouse never calculate action #2059

merged 1 commit into from
Oct 28, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Oct 27, 2020

Changes

  • Always returns is_calculating=False immediately as clickhouse doesn't have to calculate
  • Patch out the calculating of postgres actions as we don't need it

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl requested a review from EDsCODE October 27, 2020 22:51
@timgl timgl temporarily deployed to posthog-clickhouse-neve-ljdquv October 27, 2020 22:52 Inactive
@timgl timgl merged commit 0337482 into master Oct 28, 2020
@timgl timgl deleted the clickhouse-never-calculate-action branch October 28, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @EDsCODE