Dashboard empty states #2068
Dashboard empty states #2068
Conversation
|
FYI @Twixes re signup tests. @jamesefhawkins it'd be great if you can review the default app dashboard and particularly the description for each graph. |
|
|
Re @jamesefhawkins, "Default" means the previously existing default dashboard was created, let me enable the feature flag so you can see the new behavior and you can try again. |
| {item.description && ( | ||
| <div style={{ padding: '0 16px', marginBottom: 16, fontSize: 12 }}>{item.description}</div> | ||
| )} | ||
|
|
There was a problem hiding this comment.
This really should allow for editing now IMO, as the descriptions will become irrelevant and confusing when the user updates the dashboard item with some other insight than the initial one.
There was a problem hiding this comment.
I agree, I've opened #2075 to tackle this as an improvement to be able to get this in before the code freeze in the meantime.
| {item.is_sample && ( | ||
| <div className="sample-dasbhoard-overlay"> | ||
| <Button onClick={() => router.actions.push(link)}>Configure</Button> | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
It's sort of annoying that this Configure overlay just pops in on hover with no warning. I think it should be clear that this needs configuration before attempting to interact + the overlay should be less surprising and intrusive (also, something like a 200ms transition would do a lot here).
There was a problem hiding this comment.
Yup agreed, just updated, wdyt? the delay would be great, but I prefer to keep this in CSS to simplify
Changes
Closes #1694.
Closes #1695.
PR introduces the following changes:
1694-dashboards) the default web app dashboard introduced on Dashboard templates & first default dashboard #1942 will automatically be created when a new user signs up.
- Introduces a `description` attribute on `DashboardItem` which is used to add more information to the default graphs created (and adds description to the default web dashboard). In the future this attribute can also be used so users can set up their custom description.is_sampleattribute onDashboardItemto identify items that have been created by templates but that require further configuration. When the user hovers on a graph that fits that description, a CTA to configuration will appear. Whenever a dashboard is altered by a user,is_samplewill be set toFalseto indicate this is no longer a template item.api/signup.Checklist