Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobufize events to protect from malformed JSON #2085

Merged
merged 7 commits into from
Oct 28, 2020
Merged

Protobufize events to protect from malformed JSON #2085

merged 7 commits into from
Oct 28, 2020

Conversation

fuziontech
Copy link
Member

Changes

Please describe.
If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-proto2-rw02ffqsjj6kjoi October 28, 2020 22:11 Inactive
@fuziontech fuziontech merged commit 83b5273 into master Oct 28, 2020
@fuziontech fuziontech deleted the proto2 branch October 28, 2020 22:18
@mariusandra
Copy link
Collaborator

Totally unintended consequence to this PR that we probably can't do much about:

Building grpcio on heroku takes forever. Several minutes. I didn't count:

2020-10-31 08 45 51

This will be cached and fine for production (requirements cached), but each review app deploys much slower now the first time. 🤷

I'm still continuously surprised as to how slow builds on Heroku are... Running the same webpack/npm/pip scripts in any halfway decent machine finishes much faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants