Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elements chain with bad classes #2133

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Oct 30, 2020

Changes

Fixes https://sentry.io/organizations/posthog/issues/1974931991/events/74ae00ce4cb345e4991edf3d2f55df7f/?project=1899813&query=is%3Aunresolved and https://sentry.io/organizations/posthog/issues/1970615438/?project=1899813&query=is%3Aunresolved

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-fix-elements-ch-fzldc9 October 30, 2020 11:45 Inactive
@timgl timgl requested a review from macobo October 30, 2020 11:45
@macobo
Copy link
Contributor

macobo commented Oct 30, 2020

I'm not sure I understand the bug or the fix.

Is it that we sometimes send invalid data from posthog-js (a.......small)?

@timgl
Copy link
Collaborator Author

timgl commented Nov 2, 2020

Yes it's a bug we did fix in posthog-js but older versions might still be sending this etc.

@timgl timgl temporarily deployed to posthog-fix-elements-ch-fzldc9 November 2, 2020 12:12 Inactive
@timgl timgl merged commit 119a3e7 into master Nov 2, 2020
@timgl timgl deleted the fix-elements-chain-with-bad-classes branch November 2, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants