feat: Add Plugin Private Access control to model #21680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posthog/models/plugin.py
Outdated
| # Sometimes we want to test out new plugins by only enabling them for certain organizations at first | ||
| class PluginPrivateAccess(models.Model): | ||
| plugin: models.ForeignKey = models.ForeignKey("Plugin", on_delete=models.CASCADE) | ||
| organization: models.ForeignKey = models.ForeignKey("Organization", on_delete=models.CASCADE) |
There was a problem hiding this comment.
Django has ManyToManyField for this, it could be a field on the Plugin model.
I don't have a strong opinion, just pointing it out. :)
tiina303
changed the title
tiina303
changed the title
bretthoerner
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We currently determine access based on if a non deleted plugin_config exists in the organization, that's annoying to use for allowing private plugin access and it makes deprecating plugins more complex too.
Changes
馃憠 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?