Handle ChunkLoadError better #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this actually fixes the issue from a users point of view, I think people still tend to get stuck until they hard-refresh. Have you been able to reproduce that? |
|
This does the hard refresh for them though. Not sure I understand how they get stuck? |
mariusandra
approved these changes
Nov 5, 2020
|
@timgl if I understand correctly, the fix I did a long time ago still refreshes the page for the users, yet we threw the error into sentry regardless. Now the error is swallowed if we handle it. I tried locally - started webpack and closed it, then opened another page from the sidebar. The page refreshed. |
|
@mariusandra Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This should stop ChunkLoadError (which seems to happen when a user doesn't do a full page reload including assets after we redeploy the app) from spamming our Sentry issues list.