Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Preventing mousewheel from altering port value #22051

Closed
wants to merge 1 commit into from

Conversation

slshults
Copy link
Contributor

@slshults slshults commented May 2, 2024

Problem

A user pointed out (in ZenDesk ticket 11999) that the value in the port number field, in the batch export config screen, can be changed unintentionally by scrolling with the mouse wheel. This PR is to prevent that by changing the field type from number to tel.

Changes

Changed field type from number to tel on line 371 of
frontend/src/scenes/batch_exports/BatchExportEditForm.tsx

Before:
before-number

After:
CleanShot 2024-05-02 at 14 21 16

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Tested on my local (see the 'after' gif above)

@slshults slshults changed the title Preventing mousewheel from altering port value refactor: Preventing mousewheel from altering port value May 2, 2024
Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a typescript error to fix :).

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@slshults
Copy link
Contributor Author

Codespaces became displeased with the branch I used for this PR, so I created a new PR from a new branch.

@slshults slshults closed this May 10, 2024
@mariusandra mariusandra deleted the slshults-change-port-field-from-num-to-tel branch May 12, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants