-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(insights): Fall back to dataNodeLogic results and add dashboard concurrency #22181
Conversation
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wut
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would probably be safer to do this in two PRs, but let's try.
Problem
If an insight on a dashboard has an error/timeout, we can fall back to dataNodeLogic which will use another endpoint and possibly an async query to get the results after all.
Changes
propsChanged
function gets more hairy. We do want thedataNodeLogic
to load results if there aren't yet any, but we need to make it stop when the cachedResults coming from other logics are enoughDoes this work well for both Cloud and self-hosted?
n/a
How did you test this code?