Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Fall back to dataNodeLogic results and add dashboard concurrency #22181

Merged
merged 5 commits into from
May 8, 2024

Conversation

webjunkie
Copy link
Contributor

Problem

If an insight on a dashboard has an error/timeout, we can fall back to dataNodeLogic which will use another endpoint and possibly an async query to get the results after all.

Changes

  • fix again conditions: the propsChanged function gets more hairy. We do want the dataNodeLogic to load results if there aren't yet any, but we need to make it stop when the cachedResults coming from other logics are enough
  • add concurrency handling: load 2 insights at once

Does this work well for both Cloud and self-hosted?

n/a

How did you test this code?

  • clicked through various dashboards
  • let's see what tests say

@webjunkie webjunkie requested a review from mariusandra May 8, 2024 11:50
@webjunkie webjunkie changed the title fix(insights): Fall back to dataNodeLogic results fix(insights): Fall back to dataNodeLogic results and dashboard concurrency May 8, 2024
@webjunkie webjunkie changed the title fix(insights): Fall back to dataNodeLogic results and dashboard concurrency fix(insights): Fall back to dataNodeLogic results and add dashboard concurrency May 8, 2024
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wut

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented May 8, 2024

Size Change: 0 B

Total Size: 1.05 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.05 MB

compressed-size-action

Copy link
Collaborator

@mariusandra mariusandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be safer to do this in two PRs, but let's try.

@webjunkie webjunkie enabled auto-merge (squash) May 8, 2024 12:42
@webjunkie webjunkie merged commit b580b8b into master May 8, 2024
83 checks passed
@webjunkie webjunkie deleted the feature/dashboard-concurrency branch May 8, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants