-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(insights): Add concurrent refresh of insights on dashboard #22197
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a21a18d
Fix dataNodeLogic results overwritten itself by propsChanged
webjunkie 67285cf
Fix test
webjunkie c0654b6
Merge branch 'master' into fix/insight-loading-try2
webjunkie 366a450
Revert unrelated changes
webjunkie 8ec0d10
Merge branch 'master' into feature/dashboard-concurrency
webjunkie 88049d8
Update UI snapshots for `chromium` (1)
github-actions[bot] d33f8b5
Update UI snapshots for `chromium` (1)
github-actions[bot] f82be39
Adjust run with limit
webjunkie 6a3b1d0
Merge branch 'master' into feature/dashboard-concurrency
webjunkie fbabe2c
Use Set
webjunkie 2d08fac
Adjust
webjunkie c469a2d
Update UI snapshots for `chromium` (2)
github-actions[bot] 74a654b
Update UI snapshots for `chromium` (2)
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just finding this pretty hard to read in a recursive form (which also applied to
loadNextPromise()
), so I'm wondering if this routine can be made iterative?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!