Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Preventing mousewheel from altering port value in batch export form #22258

Merged
merged 2 commits into from
May 24, 2024
Merged

refactor: Preventing mousewheel from altering port value in batch export form #22258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04865af
Preventing mousewheel from altering port value
slshults May 10, 2024
2b0e239
adding `min` and `max` to LemonInputPropsText definition
slshults May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/lib/lemon-ui/LemonInput/LemonInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ interface LemonInputPropsBase
}

export interface LemonInputPropsText extends LemonInputPropsBase {
type?: 'text' | 'email' | 'search' | 'url' | 'password' | 'time'
type?: 'text' | 'email' | 'search' | 'url' | 'password' | 'time' | 'tel'
value?: string
defaultValue?: string
onChange?: (newValue: string) => void
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/scenes/batch_exports/BatchExportEditForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@
</LemonField>

<LemonField name="port" label="Port">
<LemonInput placeholder="5432" type="number" min="0" max="65535" />
<LemonInput placeholder="5432" type="tel" min="0" max="65535" />

Check failure on line 394 in frontend/src/scenes/batch_exports/BatchExportEditForm.tsx

View workflow job for this annotation

GitHub Actions / Code quality checks 

Type '{ placeholder: string; type: "tel"; min: string; max: string; }' is not assignable to type 'IntrinsicAttributes & ((Pick<LemonInputPropsText, "prefix" | "type" | "size" | "className" | "value" | "disabled" | "id" | "onKeyDown" | ... 22 more ... | "transparentBackground"> | Pick<...>) & RefAttributes<...>)'.
</LemonField>

<LemonField name="database" label="Database">
Expand Down Expand Up @@ -456,7 +456,7 @@
</LemonField>

<LemonField name="port" label="Port">
<LemonInput placeholder="5439" type="number" min="0" max="65535" />
<LemonInput placeholder="5439" type="tel" min="0" max="65535" />

Check failure on line 459 in frontend/src/scenes/batch_exports/BatchExportEditForm.tsx

View workflow job for this annotation

GitHub Actions / Code quality checks 

Type '{ placeholder: string; type: "tel"; min: string; max: string; }' is not assignable to type 'IntrinsicAttributes & ((Pick<LemonInputPropsText, "prefix" | "type" | "size" | "className" | "value" | "disabled" | "id" | "onKeyDown" | ... 22 more ... | "transparentBackground"> | Pick<...>) & RefAttributes<...>)'.
</LemonField>

<LemonField name="database" label="Database">
Expand Down
Loading