fix(lemon-ui): Fix overlap of highlighted sticky table cells #22437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
commented
May 22, 2024
Comment on lines
-186
to
-190
| .experiment-view { | ||
| .InsightViz .LemonTable__cell--sticky::before { | ||
| background: var(--bg-table); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this isn't needed after this refactor, but please double-check
|
Size Change: 0 B Total Size: 1.05 MB ℹ️ View Unchanged
|
daibhin
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #22393!
Changes
We now set an opaque background on the sticky cells themselves, and only use
::beforefor highlighting. This way sticky cells always are opaque, and the overlapping effect is gone.