Allow logged in users to join from invite #2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
reviewed
Nov 5, 2020
mariusandra
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
Some comments below, but looks good enough to me. Approved! See yourself if there's anything to change or not.
Sorry this took so long to get through. I've been very far from the organization work and this took a big context switch (and 1h) to get through, thus I kept putting it off for a week...
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously carried over invite view behavior from the old Team-based way, but now users can be in multiple organizations, so this allows existing, logged in users to join another organization from an invite link.