Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reload sessions on closing player #2261

Merged
merged 1 commit into from Nov 6, 2020
Merged

Don't reload sessions on closing player #2261

merged 1 commit into from Nov 6, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Nov 6, 2020

Changes

Each time you closed the sessions player we'd reload the sessions table as well, making it feel pretty slow. This PR avoids that reload

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl requested a review from macobo November 6, 2020 11:24
@timgl timgl temporarily deployed to posthog-dont-reload-ses-wbvk5h November 6, 2020 11:25 Inactive
@macobo
Copy link
Contributor

macobo commented Nov 6, 2020

Thanks for the fix. Marius mentioned that some of the url navigation stuff is tricky, and it sure is!

@macobo macobo merged commit 5d80614 into master Nov 6, 2020
@macobo macobo deleted the dont-reload-sessions-on-closing-player branch November 6, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo Awaiting requested review from macobo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @macobo