Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix people filtering with entity filters #2265

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fix people filtering with entity filters #2265

merged 1 commit into from
Nov 9, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Nov 6, 2020

Changes

Previously, if you had set properties on an entity in trends (rather than on the entire trends filter) clicking on a point on the graph to load the people wouldn't actually be filtered by those properties.

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl requested a review from EDsCODE November 6, 2020 18:31
@timgl timgl temporarily deployed to posthog-fix-people-filt-9t1tz7 November 6, 2020 18:32 Inactive
yakkomajuri
yakkomajuri approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@yakkomajuri yakkomajuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funnels didn't load on the preview env but checked deployments for other PRs and that seems to be the case across the board, for whatever reason.

@timgl timgl merged commit 3c97747 into master Nov 9, 2020
@timgl timgl deleted the fix-people-filtering-with-entity-filters branch November 9, 2020 17:55
EDsCODE added a commit that referenced this pull request Nov 9, 2020
@EDsCODE
Revert "Fix people filtering with entity filters (#2265)"
8ff5b72 
This reverts commit 3c97747.
@EDsCODE EDsCODE mentioned this pull request Nov 9, 2020
Merged
EDsCODE added a commit that referenced this pull request Nov 9, 2020
@EDsCODE
Revert "Fix people filtering with entity filters (#2265)" (#2291)
ed7d075 
This reverts commit 3c97747.
EDsCODE added a commit that referenced this pull request Nov 9, 2020
@EDsCODE
Revert "Revert "Fix people filtering with entity filters (#2265)" (#2291
d61172f 
)"

This reverts commit ed7d075.
EDsCODE added a commit that referenced this pull request Nov 9, 2020
@EDsCODE
Revert "Revert "Fix people filtering with entity filters (#2265)" (#2291
31575bc 
)" (#2294)

This reverts commit ed7d075.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakkomajuri yakkomajuri yakkomajuri approved these changes

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @yakkomajuri