Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cohort query missing filters #2299

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fix cohort query missing filters #2299

merged 1 commit into from
Nov 9, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Nov 9, 2020

Changes

Please describe.

  • action based cohort query was missing the right comparison because it needs 'distinct_id IN ' rather than 'person_id IN'
  • inner query needs to have team_id filter otherwise events table filters all events
    If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-patch-cohort-qu-qpbotp November 9, 2020 23:01 Inactive
@EDsCODE EDsCODE merged commit 7bcbd44 into master Nov 9, 2020
@EDsCODE EDsCODE deleted the patch-cohort-querying branch November 9, 2020 23:17
@macobo macobo mentioned this pull request Nov 10, 2020
Closed
@macobo macobo mentioned this pull request Jan 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo Awaiting requested review from macobo

@fuziontech fuziontech Awaiting requested review from fuziontech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EDsCODE @timgl