Fix local static file host on Windows #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Addresses a Windows specific issue following on from #1912.
0.0.0.0is non-routable address that a browser won't connect to. Linux helps out by converting that to127.0.0.1automatically but Windows does not.On local deployment the frontend server is set to listen on
0.0.0.0which is correct, but the client also uses this as the host address to connect to the server which results in an error on Windows.This PR keeps the server listening on
0.0.0.0(or whateverWEBPACK_HOT_RELOAD_HOSTis set to), but changes the address on the client end to point to localhost (orWEBPACK_HOT_RELOAD_HOSTif set).Checklist
All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).Django backend tests (if this PR affects the backend).