Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hidden Properties Display State #2326

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Fix Hidden Properties Display State #2326

merged 1 commit into from
Nov 11, 2020

Conversation

yakkomajuri
Copy link
Contributor

@yakkomajuri yakkomajuri commented Nov 10, 2020 •
edited
Loading

Changes

Please describe.
If this affects the front-end, include screenshots.

Closes #1928

Hidden properties will now be added to the bottom of the list when made visible.

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-fix-hidden-prop-todz1j November 10, 2020 21:20 Inactive
@yakkomajuri yakkomajuri merged commit 2649e34 into master Nov 11, 2020
@yakkomajuri yakkomajuri deleted the fix-hidden-props branch November 11, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hidden properties applied to the middle of the list
3 participants
@yakkomajuri @macobo @timgl