Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hog): autocomplete #23332

Merged
merged 8 commits into from
Jun 28, 2024
Merged

feat(hog): autocomplete #23332

merged 8 commits into from
Jun 28, 2024

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Jun 28, 2024

Problem

We have HogQL autocomplete, but not Hog autocomplete.

Changes

Adds autocomplete in Hog for:

  • all functions
  • all variables in scope

2024-06-28 17 18 33

How did you test this code?

Added a test

Copy link
Contributor

github-actions bot commented Jun 28, 2024

Size Change: 0 B

Total Size: 1.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.06 MB

compressed-size-action

@mariusandra mariusandra marked this pull request as ready for review June 28, 2024 15:19
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooooohhhhh

@mariusandra mariusandra enabled auto-merge (squash) June 28, 2024 15:30
@mariusandra mariusandra mentioned this pull request Jun 28, 2024
40 tasks
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@mariusandra mariusandra merged commit 0db8b48 into master Jun 28, 2024
91 checks passed
@mariusandra mariusandra deleted the hog-autocomplete branch June 28, 2024 16:13
tomasfarias pushed a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants