Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize logic #2358

Merged
merged 7 commits into from
Nov 18, 2020
Merged

Organize logic #2358

merged 7 commits into from
Nov 18, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Nov 12, 2020 •
edited
Loading

Changes

Please describe.

  • splits trends and sessions clickhouse logic into separate files in a directory. A lot of the helper functions were specifically used once so I split the logic into classes that compose into a overarching class

If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-ch-cleanup-fgkc9jolaqt November 12, 2020 19:48 Inactive
@EDsCODE EDsCODE marked this pull request as ready for review November 12, 2020 20:52
@timgl timgl temporarily deployed to posthog-ch-cleanup-ym0sfsevake November 12, 2020 21:19 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-ch-cleanup-ym0sfsevake November 12, 2020 21:20 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-ch-cleanup-ym0sfsevake November 12, 2020 21:30 Inactive
@EDsCODE EDsCODE requested a review from timgl November 16, 2020 14:24
@timgl timgl merged commit ec64e46 into master Nov 18, 2020
@timgl timgl deleted the ch-cleanup branch November 18, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl timgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EDsCODE @timgl