Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation with actions & events #2401

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Fix navigation with actions & events #2401

merged 3 commits into from
Nov 17, 2020

Conversation

paolodamico
Copy link
Contributor

Closes #2393

@timgl timgl temporarily deployed to posthog-fix-actions-eve-6suamc November 16, 2020 18:50 Inactive
@timgl
Copy link
Collaborator

timgl commented Nov 16, 2020

I wonder if it's confusing to again separate actions and events, and if it wouldn't be better to just have them under one item? Will also reduce the number of items in the sidebar

@timgl timgl temporarily deployed to posthog-fix-actions-eve-6suamc November 17, 2020 02:40 Inactive
@paolodamico
Copy link
Contributor Author

You're right, that makes sense! I've removed the "Actions" item from the main navigation bar, but kept the logic to support custom scene handling stuff in case we want for instance add a specific insights item (e.g. funnels) directly to the menu.

Two small changes included in the PR too:

  1. Fixes a small bug in which if you clicked the "Events" nav item and you were in a different tab, you were not taken to the main events tab.
  2. Changed /events/events to /events/stats for more clarity.

@timgl timgl merged commit 0725d11 into master Nov 17, 2020
@timgl timgl deleted the fix-actions-events-nav branch November 17, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation broken between events and actions
2 participants