Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cohorts not being calculated #2404

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fix cohorts not being calculated #2404

merged 1 commit into from
Nov 16, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Nov 16, 2020

Changes

See this Sentry error. I'm not sure why this argument was added but it wasn't called when scheduling. I think this also means cohorts are broken for self-hosted users, so this is a release blocking fix?

@macobo thoughts?

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl requested a review from macobo November 16, 2020 19:44
@timgl timgl temporarily deployed to posthog-fix-cohorts-not-koxqwd November 16, 2020 19:45 Inactive
@macobo
Copy link
Contributor

macobo commented Nov 16, 2020

so this is a release blocking fix?

Agreed!

@timgl timgl merged commit 1ec12f2 into master Nov 16, 2020
@timgl timgl deleted the fix-cohorts-not-being-calculated branch November 16, 2020 19:56
timgl added a commit that referenced this pull request Nov 17, 2020
@timgl
Fix cohorts not being calculated (#2404)
8cc652c
@timgl timgl mentioned this pull request Nov 17, 2020
Merged
3 tasks
yakkomajuri added a commit that referenced this pull request Nov 17, 2020
@yakkomajuri @timgl
Release 1.17.0 (#2417)
308520d 
* Add actions to sidebar (#2402)

* Fix cohorts not being calculated (#2404)

* Fix heroku image (#2414)

* Fix cohorts (#2415)

* Bump version 1.17.0

Co-authored-by: Tim Glaser <tim.glaser@hiberly.com>
Co-authored-by: Tim Glaser <tim@glsr.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @macobo