Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retention graph and multiple event fix #2405

Merged
merged 43 commits into from
Nov 26, 2020
Merged

Retention graph and multiple event fix #2405

merged 43 commits into from
Nov 26, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Nov 16, 2020 •
edited
Loading

Changes

Please describe.

  • implements Retention cohorts graphs #1936
  • changes how multiple event retention works. Previously, it just naively filtered for both events for the returning event when recurring was selected. Now, it properly cohortizes based on the initial event
  • adds a subclass of filter for retention specific params

If this affects the front-end, include screenshots.

Checklist

  • click on person to show
  • QA clickhouse implementation
  • make labelling more clear
  • implement adding to dashboard

@timgl timgl temporarily deployed to posthog-1936-retention--gledmk November 16, 2020 20:01 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 16, 2020 20:06 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 16, 2020 20:14 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 16, 2020 22:12 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 17, 2020 19:44 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 17, 2020 19:50 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 17, 2020 19:52 Inactive
@EDsCODE EDsCODE changed the title 1936 retention graph Retention graph and multiple event fix Nov 17, 2020
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 17, 2020 23:08 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 18, 2020 01:57 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 18, 2020 02:25 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 18, 2020 15:31 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 18, 2020 15:40 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 19, 2020 15:12 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 19, 2020 15:35 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 19, 2020 15:43 Inactive
@EDsCODE EDsCODE requested review from timgl and fuziontech and removed request for timgl November 19, 2020 18:05
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 23, 2020 13:59 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 23, 2020 14:21 Inactive
@EDsCODE EDsCODE mentioned this pull request Nov 24, 2020
Merged
4 tasks
@timgl
Copy link
Collaborator

timgl commented Nov 24, 2020

some merge conflicts introduced by #2485

@EDsCODE EDsCODE had a problem deploying to posthog-1936-retention--gledmk November 26, 2020 00:20 Failure
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 26, 2020 00:34 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--gledmk November 26, 2020 00:40 Inactive
@EDsCODE
Copy link
Member Author

EDsCODE commented Nov 26, 2020

fixed!

@timgl timgl merged commit e908579 into master Nov 26, 2020
@timgl timgl deleted the 1936-retention-graph branch November 26, 2020 14:18
timgl added a commit that referenced this pull request Nov 26, 2020
@timgl
Revert "Retention graph and multiple event fix (#2405)"
5444bb3 
This reverts commit e908579.
@timgl timgl mentioned this pull request Nov 26, 2020
Merged
timgl added a commit that referenced this pull request Nov 26, 2020
@timgl
Revert "Retention graph and multiple event fix (#2405)" (#2532)
260b999 
This reverts commit e908579.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuziontech fuziontech Awaiting requested review from fuziontech

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EDsCODE @timgl