Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty actions in cohorts #2411

Merged
merged 3 commits into from
Nov 18, 2020
Merged

Fix empty actions in cohorts #2411

merged 3 commits into from
Nov 18, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Nov 17, 2020

Changes

Fixes this sentry error amongst other things. Just makes sure that if an action doesn't have any steps we make sure that part of the query doesn't match

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-fix-empty-actio-jjmdnd November 17, 2020 10:23 Inactive
@timgl timgl temporarily deployed to posthog-fix-empty-actio-jjmdnd November 17, 2020 13:26 Inactive
@timgl timgl temporarily deployed to posthog-fix-empty-actio-jjmdnd November 17, 2020 17:54 Inactive
@timgl timgl requested a review from EDsCODE November 17, 2020 20:44
@timgl timgl merged commit b41381c into master Nov 18, 2020
@timgl timgl deleted the fix-empty-actions-in-cohorts branch November 18, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @EDsCODE