Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show gradient on scrollable Select elements #2453

Merged
merged 4 commits into from
Nov 24, 2020

Conversation

adamb70
Copy link
Contributor

@adamb70 adamb70 commented Nov 20, 2020

Changes

Fixes #2050. This makes scrollable select inputs more obvious on browsers with hidden scrollbars.

chrome-capture

Adds an extended Ant Select element that should be a drop-in replacement.

I've only applied it to the Filters, Breakdowns, and Path Start Points for now, wasn't sure if anywhere else needed it.

First time using React, so let me know if I made any atrocities!

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@adamb70 adamb70 changed the title Add SelectGradientOverflow component Show gradient on scrollable Select elements Nov 20, 2020
@Twixes Twixes requested a review from EDsCODE November 23, 2020 11:08
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks a lot, this is nice! I added a gradient at the top too for symmetry (when not at the top of the list).

Gradients

Just one idea for improvement is animating this – a ~200ms transition could make this look much smoother.

@macobo macobo merged commit 433a37c into PostHog:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insights filters aren't obviously scrollable
3 participants