Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DATABASE_URL if none found #2454

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Create DATABASE_URL if none found #2454

merged 1 commit into from
Nov 20, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

  • Under helm charts we don't pass DATABASE_URL, but a bunch of different envs
  • This PR consolidates them into DATABASE_URL, which is then exported for the plugin server
  • There's simliar logic to create REDIS_URL somewhere lower in the file

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@mariusandra mariusandra mentioned this pull request Nov 20, 2020
Merged
@timgl timgl temporarily deployed to posthog-settings-databa-uu54zy November 20, 2020 16:31 Inactive
@yakkomajuri yakkomajuri merged commit dead5d8 into master Nov 20, 2020
@yakkomajuri yakkomajuri deleted the settings-database-url branch November 20, 2020 18:38
mariusandra added a commit that referenced this pull request Nov 24, 2020
@mariusandra
create DATABASE_URL env if none found (#2454)
d0e8789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakkomajuri yakkomajuri yakkomajuri approved these changes

Assignees

@timgl timgl

@Twixes Twixes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mariusandra @yakkomajuri @timgl @Twixes