Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't record session player #2455

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Don't record session player #2455

merged 1 commit into from
Nov 20, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Nov 20, 2020

Changes

We were recording the session player which cause a crazy amount of events happening

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl requested a review from macobo November 20, 2020 16:55
@macobo
Copy link
Contributor

macobo commented Nov 20, 2020

What was this blowing up -> link?

@timgl timgl temporarily deployed to posthog-dont-record-pla-6fi073 November 20, 2020 16:57 Inactive
@timgl
Copy link
Collaborator Author

timgl commented Nov 20, 2020

If you open literally any session recording this will happen, just look at your network tab!

@timgl timgl merged commit 1a1beaa into master Nov 20, 2020
@timgl timgl deleted the dont-record-player branch November 20, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @macobo