Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Password Change #2467

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Fix Password Change #2467

merged 2 commits into from
Nov 23, 2020

Conversation

yakkomajuri
Copy link
Contributor

Changes

Please describe.
If this affects the front-end, include screenshots.

We were checking for oldPassword whereas the PATCH request was sending currentPassword.

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@Twixes Twixes temporarily deployed to posthog-fix-password-ch-dhrxrq November 23, 2020 10:58 Inactive
@Twixes Twixes merged commit 97af9fa into master Nov 23, 2020
@Twixes Twixes deleted the fix-password-change-typo branch November 23, 2020 11:06
Twixes
Twixes reviewed Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yakkomajuri @Twixes @timgl