Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for duplicate invites #2481

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Allow for duplicate invites #2481

merged 4 commits into from
Nov 24, 2020

Conversation

Twixes
Copy link
Collaborator

@Twixes Twixes commented Nov 24, 2020

Changes

So as to resolve #2260, this allows for duplicate invites without erroring out. Less friction this way and there isn't really a downside, especially with #2482.

@Twixes Twixes requested a review from timgl November 24, 2020 01:02
@timgl timgl temporarily deployed to posthog-2260-already-in-tcfibl November 24, 2020 01:04 Inactive
@Twixes Twixes temporarily deployed to posthog-2260-already-in-lno2mo November 24, 2020 01:28 Inactive
@Twixes Twixes temporarily deployed to posthog-2260-already-in-lno2mo November 24, 2020 02:00 Inactive
@timgl timgl temporarily deployed to posthog-2260-already-in-lno2mo November 24, 2020 13:18 Inactive
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! just added a small test to cover the case of multiple invites

@Twixes Twixes temporarily deployed to posthog-2260-already-in-lno2mo November 24, 2020 13:47 Inactive
@Twixes Twixes merged commit ac1f6ff into master Nov 24, 2020
@Twixes Twixes deleted the 2260-already-invited branch November 24, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return a nicer error when inviting someone who's already invited
3 participants