Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2508 Fix cohort days #2543

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Closes #2508 Fix cohort days #2543

merged 1 commit into from
Nov 27, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Nov 27, 2020

Changes

When trying to save groups we sometimes save it as string. Just parse it instead of not allowing cohort to save.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-fix-cohort-days-ioccah November 27, 2020 11:06 Inactive
@mariusandra mariusandra merged commit a724a83 into master Nov 27, 2020
@mariusandra mariusandra deleted the fix-cohort-days branch November 27, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @mariusandra