Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unclickable prop filter #2572

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Fix unclickable prop filter #2572

merged 3 commits into from
Nov 30, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Nov 30, 2020

Changes

Please describe.

  • With the new PropertyFilterButton component, it was missing a function handler so that you can reopen the popover to edit the filter
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-static-property-itcayr November 30, 2020 18:53 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-static-property-itcayr November 30, 2020 20:07 Inactive
@EDsCODE EDsCODE merged commit 5967d03 into master Nov 30, 2020
@EDsCODE EDsCODE deleted the static-property-filter-bug branch November 30, 2020 20:09
@EDsCODE EDsCODE mentioned this pull request Nov 30, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

@paolodamico paolodamico Awaiting requested review from paolodamico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EDsCODE @timgl