-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved session player navigation #2611
Conversation
Feedback:
Issues:
|
@macobo thanks for the thorough review, great catches! I've addressed all your feedback and greatly simplified the logic of sessionsTable, please feel free to review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I'd merge this and make a PR for the scroll bar issue but merging the other pr caused a merge conflict 😅
Changes
Updates the way the session player is opened to be shown in the same page to provide a smoother experience.
Default behavior. In place player
![image](https://user-images.githubusercontent.com/5864173/100800028-98dec700-33eb-11eb-806c-5a4b9c3bd692.gif)
Cmd/Cntrl + click. Open in new tab
![image](https://user-images.githubusercontent.com/5864173/100800077-aeec8780-33eb-11eb-99d4-82289eca0619.gif)
Removes the legacy drawer (and related feature flag [
full-page-player
]).Removes standalone session player page on
/sessions/play?id={id}
because it's redundant now with/sessions?sessionRecordingId={id}
Fixes some TS bugs in session recording.
Checklist