Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release actions-ux-201012 #2615

Merged
merged 9 commits into from
Dec 3, 2020
Merged

Release actions-ux-201012 #2615

merged 9 commits into from
Dec 3, 2020

Conversation

paolodamico
Copy link
Contributor

Changes

Terminates the experiment introduced by #1841. Based on results, we're releasing the new code following the positive outcome. This PR removes all the legacy code and terminates the feature flag usage.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-release-actions-redbtj December 2, 2020 00:39 Inactive
@timgl timgl temporarily deployed to posthog-release-actions-redbtj December 2, 2020 00:44 Inactive
@timgl timgl temporarily deployed to posthog-release-actions-redbtj December 2, 2020 00:56 Inactive
@timgl timgl temporarily deployed to posthog-release-actions-redbtj December 2, 2020 01:04 Inactive
@timgl timgl temporarily deployed to posthog-release-actions-redbtj December 2, 2020 01:17 Inactive
@timgl
Copy link
Collaborator

timgl commented Dec 2, 2020

One bit of feedback I got from a users was that this was very confusing:
image

What happened was they had set the autocapture on the left and accidentally clicked the plus on the right. They hadn't realised the right group was matching "OR" and thus matching each pageview. I think it should be more obvious these boxes are 'match groups'.

@timgl timgl temporarily deployed to posthog-release-actions-redbtj December 2, 2020 23:53 Inactive
@paolodamico
Copy link
Contributor Author

Thanks for the review @timgl, addressed it with:

  • Showing a title on each match group
  • When a user adds a match group but doesn't even make a type of event ($autocapture, $pageview, event) selection, the group will not be saved.

In addition, the type switcher is now centered in the match group when a selection has not been made. This is to address the case when you have scrolled (because the match group to the side has a large height) and you would no longer see the type of event selector.

image

Ready for a full review!

@timgl timgl merged commit d6f3079 into master Dec 3, 2020
@timgl timgl deleted the release-actions-ux-201012 branch December 3, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants