Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: When clicking 'add action/event', populate the generated event with last event data #2635

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Dec 2, 2020

In my usecase I was analyzing $capture_failed_request with different
percentiles/math operators on the same properties. Doing this was
slightly painful, since I needed to enter the same data over and over
again.

After this change we'll populate the action/event with last row.
My hypothesis is this will speed things up generally.

Peek 2020-12-02 20-46

Note that I'm not confident in this change - feel free to raise any counter-arguments.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@macobo macobo requested a review from timgl December 2, 2020 18:47
@timgl timgl temporarily deployed to posthog-proposal-add-ac-grjygw December 2, 2020 18:49 Inactive
@EDsCODE
Copy link
Member

EDsCODE commented Dec 2, 2020

I think this makes sense but the UX of it could feel abrupt/unplanned. I'm tempted to add it as a split button where the repeat option will be in the dropdown so that the user intent is clear when they want to repeat something

@macobo
Copy link
Contributor Author

macobo commented Dec 3, 2020

I'd rather not add a second button here (would feel over-complicated) and rather drop this PR if that's the case. Was just easier to open a PR rather than discussing this first.

@timgl
Copy link
Collaborator

timgl commented Dec 7, 2020

I'm in favour of merging this. I am much more likely to want to re-use the event I've selected earlier than going back to $pageview.

One small change is that I'd like the filter to open automatically. In screenshot below, it's not super obvious that the second row has filters applied as well.
image

…ent with last event data

In my usecase I was analyzing $capture_failed_request with different
percentiles/math operators on the same properties. Doing this was
slightly painful, since I needed to enter the same data over and over
again.

After this change we'll populate the action/event with last row.
My hypothesis is this will speed things up generally.
@macobo
Copy link
Contributor Author

macobo commented Dec 14, 2020

The suggestion above has been solved - merging this for now. :)

@macobo macobo merged commit 3143340 into master Dec 14, 2020
@macobo macobo deleted the proposal-add-action-event branch December 14, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants