-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1842 link to edit cohort #2694
1842 link to edit cohort #2694
Conversation
Hi @girlProg! Thanks for this. Looks like our e2e pipeline is being flaky as your addition should be clear from these tests. I'll rerun the pipeline and get it merged afterwards! |
hey @EDsCODE, you're welcome :) |
@EDsCODE not sure but they all seem to be failing over (the same?) assertion ? |
If you merge master and push again, tests will pass correctly. |
@paolodamico sorry does this require a new pull request? as this PR is referencing the branch not master |
Hey @girlProg, no new PR needed, just do git fetch && git merge master, push and you should be good to go. |
…-link-to-edit-cohort
oh great! did the merge the other way around and couldn't seem to undo the merge. yay! will definitely send the email. thank you for the help! |
Changes
you can now view/edit a cohort filter by clicking on the View button beside the selected cohort.
![Screenshot 2020-12-07 at 22 30 05](https://user-images.githubusercontent.com/3257699/101410119-284e1380-38df-11eb-8e75-ed17e2ffc69a.png)
Opens in new tab
Checklist