Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1842 link to edit cohort #2694

Merged
merged 4 commits into from
Dec 8, 2020

Conversation

girlProg
Copy link
Contributor

@girlProg girlProg commented Dec 7, 2020

Changes

you can now view/edit a cohort filter by clicking on the View button beside the selected cohort.
Opens in new tab
Screenshot 2020-12-07 at 22 30 05

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@EDsCODE
Copy link
Member

EDsCODE commented Dec 7, 2020

Hi @girlProg! Thanks for this. Looks like our e2e pipeline is being flaky as your addition should be clear from these tests. I'll rerun the pipeline and get it merged afterwards!

@girlProg
Copy link
Contributor Author

girlProg commented Dec 7, 2020

hey @EDsCODE, you're welcome :)
I was starting to wonder how the tests were failing. Great then. Thanks!

@girlProg
Copy link
Contributor Author

girlProg commented Dec 7, 2020

@EDsCODE not sure but they all seem to be failing over (the same?) assertion ?
Screenshot 2020-12-07 at 23 29 15

@paolodamico
Copy link
Contributor

If you merge master and push again, tests will pass correctly.

@girlProg
Copy link
Contributor Author

girlProg commented Dec 7, 2020

If you merge master and push again, tests will pass correctly.

@paolodamico sorry does this require a new pull request? as this PR is referencing the branch not master

@paolodamico
Copy link
Contributor

Hey @girlProg, no new PR needed, just do git fetch && git merge master, push and you should be good to go.

@paolodamico
Copy link
Contributor

Will merge now because failing test is unrelated and already fixed in #2674. Thanks for the contribution @girlProg, please be sure to email yakko[at]posthog{.}com to get some official PostHog merch 😄

@girlProg
Copy link
Contributor Author

girlProg commented Dec 8, 2020

oh great! did the merge the other way around and couldn't seem to undo the merge. yay! will definitely send the email. thank you for the help!

@paolodamico paolodamico merged commit 1835174 into PostHog:master Dec 8, 2020
@paolodamico paolodamico mentioned this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants