Support gzip encoding from posthog-js #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is subtly different from `gzip` since it requires text/plain encoding (we can't send application/json due to CORS). We need a separate name for this because of this as older versions of posthog don't support text/plain
6 tasks
paolodamico
reviewed
Dec 8, 2020
| @@ -155,6 +155,24 @@ def test_emojis_in_text(self, patch_process_event_with_plugins): | |||
| "💻 Writing code", | |||
| ) | |||
|
|
|||
| @patch("posthog.models.team.TEAM_CACHE", {}) | |||
| @patch("posthog.api.capture.celery_app.send_task") | |||
| def test_js_gzip(self, patch_process_event_with_plugins): | |||
There was a problem hiding this comment.
Maybe worth adding a test for an incorrectly formatted payload with gzip-js to make sure it's handled gracefully?
There was a problem hiding this comment.
Good question. Unsure what the expected behavior here is - silently eating errors in the util would lead to problems elsewhere.
There was a problem hiding this comment.
I'm making a proposal change for this, will just make sure a proper error response is returned instead of a cryptic 500
There was a problem hiding this comment.
Never mind, as the /capture endpoint is not on DRF, handling the exception requires a more comprehensive refactor, tabling this for now into a separate issue.
paolodamico
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR: PostHog/posthog-js#151
Checklist