Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes legacy stuff from #2709 #2710

Merged
merged 9 commits into from
Dec 9, 2020
Merged

Removes legacy stuff from #2709 #2710

merged 9 commits into from
Dec 9, 2020

Conversation

paolodamico
Copy link
Contributor

Changes

See title. Must absolutely be merged after #2709 & https://github.com/PostHog/posthog-production/pull/54. Tests will not pass after those two PRs are merged.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@timgl timgl temporarily deployed to posthog-finish-2709-ref-b1b9ux December 9, 2020 00:10 Inactive
@paolodamico paolodamico marked this pull request as ready for review December 9, 2020 16:26
@timgl timgl temporarily deployed to posthog-finish-2709-ref-b1b9ux December 9, 2020 16:28 Inactive
@paolodamico
Copy link
Contributor Author

Now waiting on https://github.com/PostHog/posthog-production/pull/56 for some missed tests.

Twixes
Twixes approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to remove dependency on this from posthog-production first.

@paolodamico paolodamico merged commit 1f72aa9 into master Dec 9, 2020
@paolodamico paolodamico deleted the finish-2709-refactor branch December 9, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paolodamico @Twixes @timgl