Sessions filtering postgres support #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EDsCODE
approved these changes
Dec 10, 2020
| if not filter._date_from: | ||
| filter._date_from = relative_date_parse("-7d") | ||
| if not filter._date_to: | ||
| filter._date_to = timezone.now() |
There was a problem hiding this comment.
Could move this into SessionFilter
There was a problem hiding this comment.
We could, but the annoying part is this requires refactoring python sessions list as well which has subtly different code. Hope it's fine I'll leave it like this for now.
| @@ -43,27 +38,9 @@ def trend(self, request: Request, *args: Any, **kwargs: Any) -> Response: | |||
|
|
|||
| @action(methods=["GET"], detail=False) | |||
| def session(self, request: Request, *args: Any, **kwargs: Any) -> Response: | |||
| response = ClickhouseSessions().run(team=self.team, filter=Filter(request=request)) | |||
There was a problem hiding this comment.
This split feels much better haha. There were too many conflicting functions here
macobo
force-pushed
the
sessions-filtering-postgres-support
branch
from
4eed4cd
to
29cd653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
After this:
I did not put the offset handling code into this query as it would have become quite expensive. Will handle that in a separate PR.
Checklist