Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Try to fix error with DAU breakdown of user properties #2793

Merged
merged 13 commits into from Dec 16, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Dec 16, 2020

This still fails a test, but fixes the original issue: two joins against
persons table were being made.

https://sentry.io/organizations/posthog/issues/2094211477/?project=1899813&query=is%3Aunresolved

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@macobo macobo requested a review from EDsCODE December 16, 2020 13:47
@macobo macobo marked this pull request as draft December 16, 2020 13:48
@timgl timgl temporarily deployed to posthog-fix-trends-brea-ptls5w December 16, 2020 13:49 Inactive
@macobo macobo force-pushed the fix-trends-breakdown-by-user branch from fcc0f3a to 770b4f7 Compare December 16, 2020 14:48
@macobo macobo temporarily deployed to posthog-fix-trends-brea-ptls5w December 16, 2020 14:48 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-fix-trends-brea-ptls5w December 16, 2020 15:08 Inactive
@EDsCODE EDsCODE marked this pull request as ready for review December 16, 2020 15:22
@macobo macobo merged commit 7cbcf07 into master Dec 16, 2020
@macobo macobo deleted the fix-trends-breakdown-by-user branch December 16, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants