New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Try to fix error with DAU breakdown of user properties #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still fails a test, but fixes the original issue: two joins against persons table were being made. https://sentry.io/organizations/posthog/issues/2094211477/?project=1899813&query=is%3Aunresolved
This still fails a test, but fixes the original issue: two joins against persons table were being made. https://sentry.io/organizations/posthog/issues/2094211477/?project=1899813&query=is%3Aunresolved
macobo
force-pushed
the
fix-trends-breakdown-by-user
branch
from
December 16, 2020 14:48
fcc0f3a
to
770b4f7
Compare
…tHog/posthog into fix-trends-breakdown-by-user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still fails a test, but fixes the original issue: two joins against
persons table were being made.
https://sentry.io/organizations/posthog/issues/2094211477/?project=1899813&query=is%3Aunresolved
Checklist